Add ability to specify older versions as a list of files #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnett
changed the title
|
I managed to fix my build issues by updating |
MarcinAman
approved these changes
May 4, 2021
| var versionsOrdering: List<String>? = defaultVersionsOrdering, | ||
| var version: String? = defaultVersion, | ||
| ) : ConfigurableBlock { | ||
| internal fun versionFromConfigurationOrModule(dokkaContext: DokkaContext): String = | ||
| version ?: dokkaContext.configuration.moduleVersion ?: "1.0" | ||
|
|
||
| internal fun allOlderVersions(): List<File> { | ||
| if (olderVersionsDir != null) | ||
| assert(olderVersionsDir!!.isDirectory) { "Supplied previous version $olderVersionsDir is not a directory!" } |
There was a problem hiding this comment.
Are kotlin's smartcasts not working here?
There was a problem hiding this comment.
It's since it's a var. I could make it a ?.let if it's an issue.
Please do a PR. Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1889. I'm not aware of a good Java globbing implementation (the JDK one doesn't use base directories) unless you already have a dependency for one. If you do I can add a setter method.
The older version directory's subfolders and the older versions list are added together, so either or both can be specified. I don't love the
olderVersionsname but I couldn't think of a better one.additionalOlderVersionsmaybe?