Add more vertical spacing to KLib dumps #225
Conversation
| final const val examples.classes/con // examples.classes/con|{}con[0] | ||
| final fun <get-con>(): kotlin/String // examples.classes/con.<get-con>|<get-con>(){}[0] | ||
|
|
There was a problem hiding this comment.
Perhaps, we should not separate const vals, vas, and vars with a newline. Looking forward to your thoughts on that matter.
There was a problem hiding this comment.
Are they sorted as different groups, e.g. consts first, vals second, vars third, or all properties alphabetically? If the latter, then we shouldn't separate them.
There was a problem hiding this comment.
Are they sorted as different groups, e.g. consts first, vals second, vars third, or all properties alphabetically? If the latter, then we shouldn't separate them.
They are sorted as different groups. Seeing them separated still looks a bit awkward, but maybe it's just because example have only a few declarations within each of these groups.
There was a problem hiding this comment.
@ilya-g I extended this test case and also added a new one, showing how grouping/sorting works with classifiers declared only for some targets.
fzhinkin
force-pushed
the
197-consider-decl-kind-when-sorting-dump
branch
from
a9a5b5a
to
41770eb
Compare
fzhinkin
force-pushed
the
196-add-more-vertical-spacing
branch
from
c1536f7
to
c07e901
Compare
fzhinkin
force-pushed
the
196-add-more-vertical-spacing
branch
from
fa9bbe7
to
e8b4f6c
Compare
Additional newlines should improve dump's readability and also improve diffs generated by the GH.
This change builds on #197, which groups declarations based on their kind.
Now, an extra newline will always be inserted before:
// Targets:meta-header,varsandfuns).Closes #196