Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests should take into account whether GKE related secrets are present besides PULP_PASSWORD #547

Open
1 task done
pmalek opened this issue Feb 7, 2023 · 0 comments
Labels
area/ci bug Something isn't working

Comments

@pmalek
Copy link
Member

pmalek commented Feb 7, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

#538 introduced e2e tests that are run when PULP_PASSWORD (needed to get a license) is present. What it didn't take into account is the fact that GOOGLE_APPLICATION_CREDENTIALS, GOOGLE_PROJECT and GOOGLE_LOCATION.

And in case of dependabot's PRs, those are not present, e.g. #546

Expected Behavior

E2E tests do not fail for dependabot's PRs.

Steps To Reproduce

No response

Kong Kubernetes Testing Framework Version

No response

Kubernetes version

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant