Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect environment in which ktf is launched and add dynamic labels/annotations to created clusters/nodes #534

Open
1 of 2 tasks
pmalek opened this issue Feb 3, 2023 · 0 comments
Assignees
Labels
area/feature New feature or request

Comments

@pmalek
Copy link
Member

pmalek commented Feb 3, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

When running in Github Actions or locally it would be beneficial to dynamically add labels/annotations to created clusters for easier reasoning what was created where.

For example: when running in Github Actions environments let's add some metadata about repo, PR number, branch etc to cluster labels as we already do it with ktf_created_by label

ResourceLabels: lo.Assign(
map[string]string{GKECreateLabel: createdByID},
b.labels,
),

Proposed Solution

No response

Additional information

No response

Acceptance Criteria

  • When ktf creates a GKE cluster on Github Actions CI I can easily find it by labels in GKE dashboard using some predefined labels that will contain metadata about the repo it was run in, PR number and branch name.
@pmalek pmalek self-assigned this Feb 3, 2023
@pmalek pmalek added the area/feature New feature or request label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant