Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a retry mechanism for fetching files from the internet #466

Open
pmalek opened this issue Dec 8, 2022 · 0 comments
Open

Introduce a retry mechanism for fetching files from the internet #466

pmalek opened this issue Dec 8, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@pmalek
Copy link
Member

pmalek commented Dec 8, 2022

Problem statement

Sometimes the framework can receive a 4xx or 5xx HTTP error code when requesting a file (like a manifest) in order to deploy/teardown an add-on. These in most cases are intermittent and should be retried since as a developer I do not want to have my full suite of tests to fail because Github returned a 503.

Example of a failed CI: https://github.com/Kong/kubernetes-testing-framework/actions/runs/3647089054/jobs/6158901046

=== RUN   TestKongWithNodePort
    kongaddon_test.go:243: configuring the testing environment, with the kong addon using NodePort service type for proxy
    kongaddon_test.go:248: building the testing environment and Kubernetes cluster
20[22](https://github.com/Kong/kubernetes-testing-framework/actions/runs/3647089054/jobs/6158901046#step:6:23)/12/08 09:48:52 well-defined vars that were never replaced: SERVICE_NAME,SERVICE_NAMESPACE
    kongaddon_test.go:250: 
        	Error Trace:	/home/runner/work/kubernetes-testing-framework/kubernetes-testing-framework/test/integration/kongaddon_test.go:[25](https://github.com/Kong/kubernetes-testing-framework/actions/runs/3647089054/jobs/6158901046#step:6:26)0
        	Error:      	Received unexpected error:
        	            	failed to deploy addon kong: Error: INSTALLATION FAILED: failed to fetch https://github.com/Kong/charts/releases/download/kong-2.13.1/kong-2.13.1.tgz : 503 Service Unavailable
        	            	: exit status 1
        	Test:       	TestKongWithNodePort
--- FAIL: TestKongWithNodePort (138.36s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant