Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error from image loader builder #440

Open
2 tasks
rainest opened this issue Nov 1, 2022 · 0 comments
Open
2 tasks

Remove error from image loader builder #440

rainest opened this issue Nov 1, 2022 · 0 comments

Comments

@rainest
Copy link
Contributor

rainest commented Nov 1, 2022

The image loader addon returns an error if given an empty string as an image. This is a relic of my old, bad design that expected this to occur because the input was an envvar.

Builders returning errors makes them annoying to work with, and callers should be responsible for not attempting to build no-op addons, not the addon. This case is ultimately handled later anyway, since Deploy() won't be able to load the non-existent image and will return an error (and addon deploy functions should return errors, unlike builders).

  • Remove the error handling from the load image builder.
  • Mark a breaking change in the changelog indicating that callers should instead check if they actually need to load an image before invoking this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant