Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ReferenceGrant resolution #6000

Open
rainest opened this issue May 10, 2024 · 0 comments
Open

Simplify ReferenceGrant resolution #6000

rainest opened this issue May 10, 2024 · 0 comments
Labels
priority/low release/not-required this is not a hard requirement for the release, it can be considered a "nice to have"
Milestone

Comments

@rainest
Copy link
Contributor

rainest commented May 10, 2024

From #5965 (comment)

Our ReferenceGrant validity check code originated in the context of GWAPI backends, and code is fairly specific to that context. We've since expanded use of them for references to Secrets and KongPlugins, and the code is a bit contrived to try and fit those other uses into the same context.

We want to refactor the ReferenceGrant handling functions into generic utilities for ReferenceGrants without regard to the objects involved in the references. Revised utilities should validate whether a requested <source namespace>:<resource GVK> -> <target resource GVK, optional name> relationship is permitted by some ReferenceGrant in the target resource namespace for any resources that satisfy the client.Object interface

@rainest rainest added this to the KIC v3.2.x milestone May 10, 2024
@rainest rainest added the release/not-required this is not a hard requirement for the release, it can be considered a "nice to have" label May 10, 2024
@lahabana lahabana modified the milestones: KIC v3.2.x, KIC 3.3.x Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low release/not-required this is not a hard requirement for the release, it can be considered a "nice to have"
Projects
None yet
Development

No branches or pull requests

2 participants