Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that FillEntityDefaults works well with non-empty zero-value fields #122

Closed
GGabriele opened this issue Jan 26, 2022 · 1 comment
Closed

Test that FillEntityDefaults works well with non-empty zero-value fields #122

GGabriele opened this issue Jan 26, 2022 · 1 comment
Assignees
@GGabriele

Comments

@GGabriele
Copy link
Collaborator

We have submitted a patch to mergo (also here) that will enable us to better handle merging non-empty zero-value fields.

Once the patch is accepted, we should add more test cases to TestFill*Defaults to test the said behaviour.
@GGabriele GGabriele self-assigned this Jan 26, 2022
@GGabriele GGabriele mentioned this issue Jan 26, 2022
Merged
@GGabriele
Copy link
Collaborator Author

#125

@hbagdi hbagdi closed this as completed Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GGabriele GGabriele

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GGabriele @hbagdi