Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list_drivers by a non-zero length buffer #124

Merged
merged 1 commit into from Nov 10, 2019

Conversation

palfrey
Copy link
Contributor

@palfrey palfrey commented Nov 10, 2019

This fixes #112. There's some argument about dropping alloc_info entirely in favour of just doing get_info and then retrying with larger buffers as needed if we fail initially, but this at least seems to sort the initial problem. I have no idea why this actually occurs, or why I can't reproduce this outside of Travis, but this does at least work.

@Koka
Copy link
Owner

Koka commented Nov 10, 2019

Thanks @palfrey that’s great! Very interesting finding!

@Koka Koka merged commit f80cd86 into Koka:master Nov 10, 2019
@palfrey palfrey deleted the fix-list-drivers-length branch November 10, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing list_drivers test
2 participants