Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow create & remove to set and remove requests for teams #845

Merged
merged 2 commits into from Jan 22, 2020

Conversation

deetergp
Copy link
Contributor

We very happily use this library to interact with the GH API. We recently came into the need for adding and removing review requests for from teams to pull requests across all of the repositories in our organization. This PR opens up GitHub\Api\PullRequest\ReviewRequest::create() and ::remove()methods to be able to do that. When removing teams from a PR, some value needs to be sent for thereviewers, hence the $reviweres = []` change.

@deetergp
Copy link
Contributor Author

@acrobat
Copy link
Collaborator

acrobat commented Jan 22, 2020

Thanks @deetergp!

@acrobat acrobat merged commit d404193 into KnpLabs:master Jan 22, 2020
@deetergp deetergp deleted the scott_addTeamPrAbilty branch February 6, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants