Allow httplug 2.0

[acrobat]

A pr to try/test if we can support both v1 and v2 of httplug. Currently there are still errors regarding typehint incompatibilities, so still a WIP to get things up and running

/cc @Nyholm is it actually possible to support both versions?

[Nyholm]

Yes, it is very possible.

Difference between version 1 and 2 of php-http/httplug is just PHP7 return types.

[acrobat]

Yes, it is very possible.

Difference between version 1 and 2 of php-http/httplug is just PHP7 return types.

@Nyholm

Ok bumping the supported php version to 7.1 (currently the oldest supported version) would kinda solve this. But the failures in travis are related about return typehints, but adding them here (and matching those of httplug) is a BC break in our lib as users could extend these classes/methods. Or am I seeing things wrong here?

[Nyholm]

Ok bumping the supported php version to 7.1

Not needed if we still support version 1.0 of httplug.

[acrobat]

@Nyholm but without bumping php we can't support httplug 2.0. So I guess the only way to do it, is to bump the major version and switch to httplug v2?

[acrobat]

Ok, this looks promising! @Nyholm I've found your PR for the mailgun api lib and so I learned that the VersionBridgePlugin class exists. The only failing tests are now caused by a final class in httplug 2.0

I will take a look next time to get these tests passing again

[acrobat]

Implementation is done and all tests are green now, but as I suspected the BC check fails now. So I guess really the only way to do it is bump the httplug requirement to v2 in the next major release?

[Nyholm]

Sorry for being slow coming back to this.

The BC warnings you see is actually fine =)

You get a bunch new from our ExceptionInterface. That is because HTTPlug starting to implement throwable. The ExceptionInterface has always intended to be implemented on an exception => which will implement these new functions... So you will only get issues if you have a non-exception and implement our ExceptionInterface.

The other "BC warnings" comes from our plugins. They use the "version bridge" to automatically adapt if you installed HTTPlug v1 or v2.

[Nyholm]

Thank you @acrobat for the work you put in to this.