Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brainstorm] Ideas for better search #727

Open
yuehuang010 opened this issue Dec 5, 2023 · 2 comments
Open

[Brainstorm] Ideas for better search #727

yuehuang010 opened this issue Dec 5, 2023 · 2 comments

Comments

@yuehuang010
Copy link
Contributor

I was using viewer to diagnose build issue(s) and trying to find ways to optimize my investigation. A few ideas came to mind that can help when comparing between two logs.

  1. "Search in subtree" is helpful but sometimes the result can exists in a different node. Consider extending with a different option like, "Search in under this project". This change will also work well when comparing from a different different binlog.
  2. $Target search should have an option to filter Skipped Targets.
  3. $start and $end should show all results or compute all of them in order to show top/bottom. As it is, the results are sorted but is sometimes misleading because not all results are present.
  4. For privacy, add a clear recent searches.
  5. Add a "searching" icon or indicator that work is processing.
  6. Add an option to ignore Evaluation.
  7. Add an option to collapse all. (Also on the log side too)
  8. Typing a "space" should not start a search.

Thank You.

@KirillOsenkov
Copy link
Owner

  1. You can combine search in subtree for multiple projects under($1) under($2) $csc. Multiple under clauses act as a union (not intersection). There's also a project clause, so you can look under specific projects project(Foo.csproj) $csc. They also combine and you can have more than one.
  2. OK
  3. you can click the button to show all results (slow), then all results will be loaded and sorted
  4. OK
  5. OK
  6. You can add a notunder(Evaluation) clause to filter out eval
  7. OK
  8. OK

@KirillOsenkov
Copy link
Owner

I wrote some help here:
https://github.com/KirillOsenkov/MSBuildStructuredLog/wiki/Search-Syntax#under-project-and-notunder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants