From ead4fbdcd4daf0309575514e3a7018ef9745d4ca Mon Sep 17 00:00:00 2001 From: Kevin222004 Date: Fri, 21 Oct 2022 10:44:40 +0530 Subject: [PATCH] Issue #12314: Resolve Pitest suppression for misc profile --- .../pitest-misc-suppressions.xml | 18 ------------------ .../checks/NewlineAtEndOfFileCheckTest.java | 8 ++++++++ .../InputNewlineAtEndOfFileCrlf3.java | 2 +- ...nputNewlineAtEndOfFileTestTrimProperty.java | 18 ++++++++++++++++++ 4 files changed, 27 insertions(+), 19 deletions(-) create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/checks/newlineatendoffile/InputNewlineAtEndOfFileTestTrimProperty.java diff --git a/.ci/pitest-suppressions/pitest-misc-suppressions.xml b/.ci/pitest-suppressions/pitest-misc-suppressions.xml index cdc3e1e5057..41c05e3b8ba 100644 --- a/.ci/pitest-suppressions/pitest-misc-suppressions.xml +++ b/.ci/pitest-suppressions/pitest-misc-suppressions.xml @@ -36,24 +36,6 @@ log(1, MSG_KEY_WRONG_ENDING, file.getPath()); - - NewlineAtEndOfFileCheck.java - com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck - setLineSeparator - org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator - replaced call to java/lang/String::toUpperCase with receiver - .toUpperCase(Locale.ENGLISH)); - - - - NewlineAtEndOfFileCheck.java - com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck - setLineSeparator - org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator - replaced call to java/lang/String::trim with receiver - Enum.valueOf(LineSeparatorOption.class, lineSeparatorParam.trim() - - OrderedPropertiesCheck.java com.puppycrawl.tools.checkstyle.checks.OrderedPropertiesCheck diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java index b0811f90749..3ff40d6411e 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java @@ -212,6 +212,14 @@ public void testWrongSeparatorLength() throws Exception { } } + @Test + public void testTrimOptionProperty() throws Exception { + final String[] expected = CommonUtil.EMPTY_STRING_ARRAY; + verifyWithInlineConfigParser( + getPath("InputNewlineAtEndOfFileTestTrimProperty.java"), + expected); + } + private static final class ReadZeroRandomAccessFile extends RandomAccessFile { private ReadZeroRandomAccessFile(String name, String mode) diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/newlineatendoffile/InputNewlineAtEndOfFileCrlf3.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/newlineatendoffile/InputNewlineAtEndOfFileCrlf3.java index c136482a121..4a66bd22d73 100644 --- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/newlineatendoffile/InputNewlineAtEndOfFileCrlf3.java +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/newlineatendoffile/InputNewlineAtEndOfFileCrlf3.java @@ -1,6 +1,6 @@ /* NewlineAtEndOfFile -lineSeparator = CRLF +lineSeparator = crlf fileExtensions = (default)all files diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/newlineatendoffile/InputNewlineAtEndOfFileTestTrimProperty.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/newlineatendoffile/InputNewlineAtEndOfFileTestTrimProperty.java new file mode 100644 index 00000000000..ecebfd084f3 --- /dev/null +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/newlineatendoffile/InputNewlineAtEndOfFileTestTrimProperty.java @@ -0,0 +1,18 @@ +/* +NewlineAtEndOfFile +lineSeparator = \tcrlf +fileExtensions = all files + + +*/ + +package com.puppycrawl.tools.checkstyle.checks.newlineatendoffile; + +/** + * Test case for detection of an existing CRLF newline at EOF, using the + * NewlineAtEndOfFileCheck. + * @author Martin Steiger + **/ +public interface InputNewlineAtEndOfFileTestTrimProperty // ok +{ +}