diff --git a/config/pitest-suppressions/pitest-coding-2-suppressions.xml b/config/pitest-suppressions/pitest-coding-2-suppressions.xml index ddd70c407b7..06586a30ffb 100644 --- a/config/pitest-suppressions/pitest-coding-2-suppressions.xml +++ b/config/pitest-suppressions/pitest-coding-2-suppressions.xml @@ -72,15 +72,6 @@ prevScopeUninitializedVariables.pop(); - - FinalLocalVariableCheck.java - com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck - leaveToken - org.pitest.mutationtest.engine.gregor.mutators.experimental.RemoveSwitchMutator_2 - RemoveSwitch 2 (case value 8) - switch (ast.getType()) { - - FinalLocalVariableCheck.java com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheckTest.java index ca5f6450dfd..30fc013d3ef 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheckTest.java @@ -307,4 +307,16 @@ public void testFinalLocalVariableSwitchStatement() throws Exception { expected); } + @Test + public void testConstructor() throws Exception { + final String[] expected = { + "14:44: " + getCheckMessage(MSG_KEY, "a"), + "17:44: " + getCheckMessage(MSG_KEY, "a"), + "17:51: " + getCheckMessage(MSG_KEY, "b"), + "20:47: " + getCheckMessage(MSG_KEY, "str"), + }; + verifyWithInlineConfigParser( + getPath("InputFinalLocalVariableConstructor.java"), + expected); + } } diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableConstructor.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableConstructor.java new file mode 100644 index 00000000000..09f52762579 --- /dev/null +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableConstructor.java @@ -0,0 +1,22 @@ +/* +FinalLocalVariable +validateEnhancedForLoopVariable = (default)false +tokens = PARAMETER_DEF + + +*/ + + +package com.puppycrawl.tools.checkstyle.checks.coding.finallocalvariable; + +public class InputFinalLocalVariableConstructor { + + InputFinalLocalVariableConstructor(int a) { // violation + } + + InputFinalLocalVariableConstructor(int a, int b) { // 2 violations + } + + InputFinalLocalVariableConstructor(String str) { // violation + } +}