From 79e911bb63612f0901458a8767c973ec9c9f5418 Mon Sep 17 00:00:00 2001 From: Kevin222004 Date: Sat, 8 Oct 2022 21:36:55 +0530 Subject: [PATCH] Issue #12267: Resolve Pitest suppression for SeperatorWrapCheck --- .../pitest-whitespace-suppressions.xml | 18 ---------------- .../whitespace/SeparatorWrapCheckTest.java | 8 +++++++ .../InputSeparatorWrapForTestDot.java | 2 +- .../InputSeparatorWrapSetOptionTrim.java | 21 +++++++++++++++++++ 4 files changed, 30 insertions(+), 19 deletions(-) create mode 100644 src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/separatorwrap/InputSeparatorWrapSetOptionTrim.java diff --git a/.ci/pitest-suppressions/pitest-whitespace-suppressions.xml b/.ci/pitest-suppressions/pitest-whitespace-suppressions.xml index 821cb2a5e7e..963bf9202e3 100644 --- a/.ci/pitest-suppressions/pitest-whitespace-suppressions.xml +++ b/.ci/pitest-suppressions/pitest-whitespace-suppressions.xml @@ -108,24 +108,6 @@ switch (ast.getType()) { - - SeparatorWrapCheck.java - com.puppycrawl.tools.checkstyle.checks.whitespace.SeparatorWrapCheck - setOption - org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator - replaced call to java/lang/String::toUpperCase with receiver - option = WrapOption.valueOf(optionStr.trim().toUpperCase(Locale.ENGLISH)); - - - - SeparatorWrapCheck.java - com.puppycrawl.tools.checkstyle.checks.whitespace.SeparatorWrapCheck - setOption - org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator - replaced call to java/lang/String::trim with receiver - option = WrapOption.valueOf(optionStr.trim().toUpperCase(Locale.ENGLISH)); - - SeparatorWrapCheck.java com.puppycrawl.tools.checkstyle.checks.whitespace.SeparatorWrapCheck diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/SeparatorWrapCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/SeparatorWrapCheckTest.java index b03ceaf4e76..1dfd05dc3b7 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/SeparatorWrapCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/SeparatorWrapCheckTest.java @@ -131,4 +131,12 @@ public void testWithEmoji() throws Exception { getPath("InputSeparatorWrapWithEmoji.java"), expected); } + @Test + public void testTrimOptionProperty() throws Exception { + final String[] expected = { + "18:44: " + getCheckMessage(MSG_LINE_NEW, "::"), + }; + verifyWithInlineConfigParser( + getPath("InputSeparatorWrapSetOptionTrim.java"), expected); + } } diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/separatorwrap/InputSeparatorWrapForTestDot.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/separatorwrap/InputSeparatorWrapForTestDot.java index 7a996e3a931..67e50f6c009 100644 --- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/separatorwrap/InputSeparatorWrapForTestDot.java +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/separatorwrap/InputSeparatorWrapForTestDot.java @@ -1,6 +1,6 @@ /* SeparatorWrap -option = NL +option = nl tokens = DOT diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/separatorwrap/InputSeparatorWrapSetOptionTrim.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/separatorwrap/InputSeparatorWrapSetOptionTrim.java new file mode 100644 index 00000000000..0edce711f0b --- /dev/null +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/separatorwrap/InputSeparatorWrapSetOptionTrim.java @@ -0,0 +1,21 @@ +/* +SeparatorWrap +option = \tNL +tokens = METHOD_REF + + +*/ + +package com.puppycrawl.tools.checkstyle.checks.whitespace.separatorwrap; + +import java.util.Arrays; + +public class InputSeparatorWrapSetOptionTrim { + + void Method() { + String[] stringArray = { "Barbara", "James", "Mary", "John", + "Patricia", "Linda" }; // violation below ''::' should be on a new line' + Arrays.sort(stringArray, String:: + compareToIgnoreCase); + } +}