Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unsupported_field_type to be ignored #189

Merged
merged 2 commits into from Apr 5, 2022

Conversation

IniterWorker
Copy link
Contributor

@IniterWorker IniterWorker commented Feb 17, 2022

@Keats,

First of all, It is my first time dealing with macro in rust.

Maybe it is not the best way to do it. But, I created a new skip validator.

  • Alternative is to ignore at compile time (inside the macro).

I would like some code review on:

  • General skip purpose
  • Necessary/Required tests

If you have any hint, you are welcome ;-)

Related to: #182

@Keats
Copy link
Owner

Keats commented Feb 19, 2022

It's not really a validator but more an attribute so I wouldn't go that way. I think it's fine to ignore all fields we cannot handle as long as they don't have a validator on them

@IniterWorker
Copy link
Contributor Author

Are you asking to remove the abort?

@Keats
Copy link
Owner

Keats commented Feb 21, 2022

I think yes, according to

/// Find the types (as string) for each field of the struct
/// Needed for the `must_match` filter
it's only for the must_match so ideally we would only check fields with validators set

@IniterWorker IniterWorker changed the title WIP: Add skip validator support Allow unsupported_field_type to be ignored Mar 23, 2022
@IniterWorker
Copy link
Contributor Author

@Keats, maybe something like that can be a beginning?

@IniterWorker IniterWorker force-pushed the feature/skip branch 2 times, most recently from 0541c57 to 3a5bd20 Compare March 23, 2022 12:36
@krojew krojew mentioned this pull request Mar 30, 2022
@Keats Keats merged commit e64a5ef into Keats:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants