Skip to content

Upgrade chrono #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 8, 2022
Merged

Upgrade chrono #741

merged 3 commits into from
Aug 8, 2022

Conversation

atezet
Copy link
Contributor

@atezet atezet commented Aug 4, 2022

Upgrade chrono the newly released version. I only ran cargo test and cargo fuzz ... (to be completely honest; it is still running) in order to check that everything still works.

@atezet atezet changed the title Upgrade chrono and chrono-tz Upgrade chrono Aug 4, 2022
@atezet
Copy link
Contributor Author

atezet commented Aug 4, 2022

I am aware of your plans to put every dependency behind its own feature flag. I still think that's a good idea (I am only using a handful), but I just wanted to get this updated as soon as possible.

@Keats
Copy link
Owner

Keats commented Aug 4, 2022

Looking at the updated versions, we should be getting the new version automatically? No need for a change afaik.

@atezet
Copy link
Contributor Author

atezet commented Aug 4, 2022

You're right, I missed that. However, wouldn't it be good to force the use of a non-vulnerable version?

@atezet
Copy link
Contributor Author

atezet commented Aug 8, 2022

@Keats Thanks for the approval. Apparently the pipeline doesn’t succeed due to a too low MSRV. Do you want me to do anything about that?

@Keats
Copy link
Owner

Keats commented Aug 8, 2022

You can either update it or I will do it

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Keats Keats mentioned this pull request Aug 8, 2022
@Keats
Copy link
Owner

Keats commented Aug 8, 2022

That's a hefty bump! I might bump the minor version of Tera when I release that

@Keats Keats merged commit 987d649 into Keats:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants