New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing webpack dep in example project package.json files #22

Closed

kylemh opened this issue Mar 29, 2022 · 1 comment · Fixed by #23

Labels

bug

kylemh commented Mar 29, 2022

https://github.com/Karibash/storybook-addon-swc/blob/main/examples/webpack4/package.json
https://github.com/Karibash/storybook-addon-swc/blob/main/examples/webpack5/package.json

The relevant webpack version should be listed... At least for Webpack 5. Without it, you run into this issue.

Karibash mentioned this issue

Make the devDependencies in the example project explicitly specify webpack #23

Merged

Owner

Karibash commented Mar 30, 2022

@kylemh
Thank you for reporting the issue.
I have fixed the issue in the following PR.
#23

Karibash closed this as completed

Karibash added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment