New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use SVGs for some stacked delims #3686
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3686 +/- ##
==========================================
- Coverage 93.39% 92.98% -0.42%
==========================================
Files 90 90
Lines 6679 6739 +60
Branches 1554 1568 +14
==========================================
+ Hits 6238 6266 +28
- Misses 403 435 +32
Partials 38 38
Continue to review full report at Codecov.
|
I'll fix the screenshotter pics tomorrow. |
@edemaine This PR is now ready for review. Since it is a purely visual effort, the best way to review it may be by looking at the screenshotter diffs for commit ae407cf. The final commit just used those images to replace the earlier ones, so it is checking against itself and won't tell you anything. |
@ronkok This sounds awesome! Thanks for working on this long-standing issue. Am I reading the screenshot diffs correctly that [QuickLaTeX rendering] (Admittedly a very small difference!) |
Re: butt line caps. You are correct. That's just sloth on my part. I can take a few minutes and create a radius. |
Line caps are rounded. Screenshots are refreshed. This PR should be ready to go. |
This is a friendly reminder that this PR is ready for review and it resolves a long-standing issue. |
Sorry, I haven't forgotten; it's just been a busy time. I will try to review next week, but if not, should definitely have time the following week. |
Thank you for the PR! I wonder whether we can get rid of these glyphs. |
## [0.16.1](v0.16.0...v0.16.1) (2022-08-28) ### Bug Fixes * Use SVGs for some stacked delims ([#3686](#3686)) ([8a65a2e](8a65a2e))
🎉 This PR is included in version 0.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks @ylemkimon!! If you have additional time, it'd be great to get your PR #3385 revised, as we recently had a request for |
This PR uses a single SVG to render certain stretchy delimiters that have until now been rendered using a stack of font glyphs. The browser's imprecision in span placement is thus evaded.
The delimiters thus treated are:
\lparen
,\rparen
,\brack
,\rbrack
,\vert
,\Vert
,\lfloor
,\rfloor
,\lceil
, and\rceil
, along with all the other functions that call the same stretchy delimiters.Resolves issues #3650 and #3168.