fix: Implement \pmb via CSS text-shadow #3505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3505 +/- ##
==========================================
- Coverage 92.98% 92.97% -0.01%
==========================================
Files 90 91 +1
Lines 6739 6765 +26
Branches 1568 1571 +3
==========================================
+ Hits 6266 6290 +24
- Misses 435 437 +2
Partials 38 38
Continue to review full report at Codecov.
|
ronkok
changed the title
|
Don't review this PR yet. There is an issue in MathML. |
|
Update: The issue that I have just found is unrelated to this PR. I was thinking that I might add the correction here, but the other issue should really be in its own PR. So this PR should be good to go. |
ylemkimon
approved these changes
Aug 29, 2022
|
🎉 This PR is included in version 0.16.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
\pmbis implemented by rendering multiple copies of the argument with small offsets. It's a kludge, as indicated by (1) the complex exceptions in the original AMS macro, and (2) actual results.This PR implements
\pmbvia CSStext-shadow. The rendering is better, particularly in large sizes and in math operators. The improvement resolves #3503.