refactor: update toSplitInto to accept delimiters object #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update toSplitInto matcher to accept the same delimiter object type that's used in renderMathInElement
Codecov Report
@@ Coverage Diff @@
## main #3444 +/- ##
=======================================
Coverage 92.98% 92.98%
=======================================
Files 90 90
Lines 6739 6739
Branches 1568 1568
=======================================
Hits 6266 6266
Misses 435 435
Partials 38 38 Continue to review full report at Codecov.
|
ylemkimon
approved these changes
Aug 29, 2022
|
Thank you for the PR! |
|
🎉 This PR is included in version 0.16.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the previous behavior before this PR?
toSplitIntoaccepted four parameters:toSplitInto: function(actual, left, right, result)and passedleftandrightin as delimiters:const split = splitAtDelimiters(actual, [{left: left, right: right, display: false}]);What is the new behavior after this PR?
toSplitIntoaccepts delimiters object:toSplitInto: function(actual, result, delimiters)as in renderMathInElement and splitAtDelimiters
Closes #2708