Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Sign Bot Commits #22

Open
techman83 opened this issue Sep 15, 2019 · 3 comments
Open

[Feature] Sign Bot Commits #22

techman83 opened this issue Sep 15, 2019 · 3 comments
Labels
Enhancement New feature or request Indexer Receives inflated modules and adds them to CKAN-meta

Comments

@techman83
Copy link
Member

It'd be really good to sign the commits that the bot makes. We now have decent infrastructure to lean against, so this wouldn't be super difficult

Requires

  • Generate a keypair
  • Figure out what bits git python need updating
  • Make it optional, managing this for dev might be annoying.
@techman83
Copy link
Member Author

I did have a look into this, the architecture for gitpython doesn't seem to allow it from my initial investigation.

@DasSkelett DasSkelett added Indexer Receives inflated modules and adds them to CKAN-meta Enhancement New feature or request labels Oct 23, 2019
@HebaruSan
Copy link
Member

Would there be a CPU/IO impact? Usually this kind of thing involves calculating hashes.

@techman83
Copy link
Member Author

I'd say negligible. You already sign yours (I really should sign mine..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request Indexer Receives inflated modules and adds them to CKAN-meta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HebaruSan @techman83 @DasSkelett