Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escalate deprecations #307

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Escalate deprecations #307

wants to merge 1 commit into from

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Oct 5, 2023 •
edited

I'll wait to merge until we're ready for 8.0.0 release.

Closes #240.

@twyatt twyatt added the major Changes that should bump the MAJOR version number label Oct 5, 2023
@twyatt twyatt added this to the 8.0.0 milestone Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Test Results

  88 files    88 suites   4s ⏱️
765 tests 756 ✔️   9 💤 0 ❌
782 runs  768 ✔️ 14 💤 0 ❌

Results for commit 8076734.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #307 (8076734) into main (1c1547e) will decrease coverage by 25.14%.
Report is 218 commits behind head on main.
The diff coverage is 47.50%.

@@              Coverage Diff              @@
##               main     #307       +/-   ##
=============================================
- Coverage     94.44%   69.30%   -25.14%     
=============================================
  Files            13        9        -4     
  Lines           126      101       -25     
  Branches          8        2        -6     
=============================================
- Hits            119       70       -49     
- Misses            6       31       +25     
+ Partials          1        0        -1
Files Coverage Δ
coroutines/src/commonMain/kotlin/flow/Combine.kt 0.00% <ø> (ø)
...tines/src/commonMain/kotlin/delay/DelayStrategy.kt 47.50% <47.50%> (ø)

... and 6 files with indirect coverage changes

@twyatt twyatt marked this pull request as ready for review October 5, 2023 20:14
@twyatt twyatt requested a review from a team as a code owner October 5, 2023 20:14
@twyatt twyatt added the do not merge PR is not ready to be merged. label Oct 5, 2023
@twyatt twyatt removed do not merge PR is not ready to be merged. labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phoenix7351 Phoenix7351 Phoenix7351 approved these changes

@cedrickcooke cedrickcooke cedrickcooke approved these changes

Assignees
No one assigned
Labels
major Changes that should bump the MAJOR version number
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Escalate Base64 functions deprecation to ERROR
3 participants
@twyatt @Phoenix7351 @cedrickcooke