-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASF's docker "latest" containers have broken ASF-ui and localization #1812
Comments
I've added awful code in 28ebc49 as a workaround, this issue will stay to remind me how ashamed of myself I should feel, until proper fix from .NET Core folks is up. |
webUI is still unavailable in docker on Raspberry Pi 4
|
Fixed in V4.2.2.1, quite funny that .NET Core changed the path just after I added a workaround for it. |
I've got the same problem here on the pre-release channel (V4.2.2.5)
|
Should work fine after you restart the image. This is a workaround, the key functionality was to fix ASF-ui, localization is more misc. |
Restarting the container doesn't solve the problem.
I see. But I'll still be looking forward to this problem getting solved. |
To the best of my knowledge localization never worked in docker containers due to missing |
Actually there seems to be no problem in handling Chinese characters. Just several minutes after I commented on this issue, I managed to solve the IPC problem and engage SteamTokenDumperPlugin. For the first time I figured out a proper configuration, I can see the log info emit by SteamTokenDumperPlugin was larded with Chinese characters (Hanzi). Though the situation there can barely be called Localization, as there is only one English word been changed (minutes -> '分') |
Localization has nothing to do with ASF being capable (or not) of handling chinese characters, ASF is UTF8 (actually Unicode) compatible and aware. You can use russian localization with chinese names for bots for example. And yes, minutes come from humanizer, this is why they were translated. |
Got it. So once we modify the dockerfile by adding |
Probably, I'm not sure, fact is that everything we do in this issue is a workaround for .NET Core bug which shouldn't (and actually is impossible to) be solved by us. You can give it a try with other docker images, such as |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This issue is supposed to be fixed with dotnet/sdk#12814 - if we're lucky, it'll make it to .NET 5.0 release. (Please avoid spamming this issue with problems unrelated to the one discussed here, especially if it has nothing to do with ASF development, thank you) |
@IceCodeNew That is an older issue of dotnet that is never resolved: dotnet/msbuild#3897. Archi has added a workaround here but it doesn't work Lines 26 to 28 in b0f3061
|
If you'd like to test if .NET 5.0 solves this issue, I've set up my docker CI to build Check #1999 for more details. |
I'm willing to help. Sadly, the problem is not solved.
|
Non-working zh-CN localization in Docker is dotnet/msbuild#3897 issue which is still not solved, not this one. Other languages should work fine. |
Got it. |
And yes, I confirmed that |
* Initial work * Fix CIs * Fix warnings * Update .travis.yml * Update dockerfiles * Update libraries to .NET 5.0 * Misc * Remove workaround for #1812 * Update cc.sh * CI updates * CI updates * Update .travis.yml
See upstream issue: dotnet/runtime#37208
The fix is actually not so obvious, as I'd need to disable the single file publish in
linux-*
OS-specific packages thatlatest
containers actually update to, and that would kill the properly working functionality on barebones Linux machines. Not the cleanest solution.If there is no good solution to this issue, I'll do that in a few days. The optimal solution would be finding out what causes this issue in docker and working it around for time being.
The text was updated successfully, but these errors were encountered: