Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug: prettier plugin collision #386

Open
3 tasks done
hyoban opened this issue Apr 12, 2024 · 6 comments
Open
3 tasks done

馃悰 Bug: prettier plugin collision #386

hyoban opened this issue Apr 12, 2024 · 6 comments
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@hyoban
Copy link

hyoban commented Apr 12, 2024

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Works fine with other prettier plugins like prettier-plugin-organize-imports.

Actual

Can not use this with prettier-plugin-organize-imports.

Additional Info

Maybe the reason is you are overriding preprocess?

babel: {
...babel.parsers.babel,
preprocess,
},
typescript: {
...typescript.parsers.typescript,
preprocess,

Some links may be useful

@hyoban hyoban added the type: bug Something isn't working :( label Apr 12, 2024
@JoshuaKGoldberg
Copy link
Owner

Can not use this with prettier-plugin-organize-imports.

Could you post a reproduction please? It's hard to triage without knowing what you mean, and this issue is pretty sparse in details.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Apr 13, 2024
@hyoban
Copy link
Author

hyoban commented Apr 14, 2024

Sorry for missing reproduction, it's here.

https://github.com/hyoban-repro/prettier-plugin-curly-collision

@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author Needs an action taken by the original poster label Apr 23, 2024
@JoshuaKGoldberg
Copy link
Owner

Gotcha - that is spooky. Thanks!

@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Apr 23, 2024
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @hyoban for bug.

馃 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 馃挋

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @hyoban! 馃帀

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@cmaciasjimenez
Copy link

I'm having the same issue with IanVS/prettier-plugin-sort-imports. There's some kind of collision and the enforced curly is not working 馃様

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

No branches or pull requests

3 participants