Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sq locale #666

Merged
merged 5 commits into from Oct 23, 2022
Merged

Adding sq locale #666

merged 5 commits into from Oct 23, 2022

Conversation

ujdhesa
Copy link
Contributor

@ujdhesa ujdhesa commented Oct 16, 2022

Please add sq locale translation to the project. TIA!

@hb20007
Copy link
Contributor

hb20007 commented Oct 17, 2022

@ujdhesa, I see that you have some non-ASCII characters in the file. We need to use Unicode escapes in the place of those characters. For example: https://github.com/JodaOrg/joda-time/blob/main/src/main/java/org/joda/time/format/messages_da.properties

@hb20007
Copy link
Contributor

hb20007 commented Oct 17, 2022

@ujdhesa Also, the space at the end of lines 3 and 4 shouldn't be there.

@ujdhesa
Copy link
Contributor Author

ujdhesa commented Oct 17, 2022

@hb2000
Just to be sure, are you talking about “ë” character?

@hb20007
Copy link
Contributor

hb20007 commented Oct 17, 2022

@hb2000
Just to be sure, are you talking about “ë” character?

Yes

@ujdhesa
Copy link
Contributor Author

ujdhesa commented Oct 17, 2022

File edited to comply with your request, @hb20007 . Thank you!

@hb20007
Copy link
Contributor

hb20007 commented Oct 17, 2022

File edited to comply with your request, @hb20007 . Thank you!

That doesn't look right. You need to use a Unicode escape. It will look like this: \u9999, where 9999 will actually be the Unicode hex value of this character.

@hb20007
Copy link
Contributor

hb20007 commented Oct 18, 2022

@ujdhesa Are you sure the uppercase U will work? (\U)

I am searching for documentation and I see that the U seems to be in lowercase everywhere. For example:

A unicode escape sequence is a backslash followed by the letter 'u' followed by four hexadecimal digits (0-9a-fA-F).

@hb20007
Copy link
Contributor

hb20007 commented Oct 18, 2022

@ujdhesa Actually, I'm sure that this is the correct one: \u00EB

For example, you can find it here: https://www.fileformat.info/info/unicode/char/eb/index.htm
Under "C/C++/Java source code"

@ujdhesa
Copy link
Contributor Author

ujdhesa commented Oct 19, 2022

@hb20007 Changed as per your request.

@hb20007
Copy link
Contributor

hb20007 commented Oct 19, 2022

@hb20007 Changed as per your request.

You also need to remove the + sign...

Copy link
Member

@jodastephen jodastephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jodastephen jodastephen merged commit 0d72960 into JodaOrg:main Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants