fix(utils): fix: some options had no effect with webpack5 #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruleSet.exec({resource: '.svg'})` was used to find `svg-sprite-loader` options object
But this approach does not work if we define a rule with something like `test: /svg-sprites.*?\.svg/`
ISSUES CLOSED: JetBrains#446
|
Any news on this PR? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #446
What kind of change does this PR introduce? (bugfix, feature, docs update, improvement)
bugfix
What is the current behavior? (You can also link to an open issue here)
ruleSet.exec({resource: '.svg'})is used to findsvg-sprite-loaderoptions object,but this approach does not work if we define a rule with something like
test: /svg-sprites.*?\.svg/And sometimes we need different loaders for different svg files, like:
What is the new behavior (if this is a feature change)?
Will scan all raw rules one by one until it will find
svg-sprite-loader, then it will break out of for-loop and will return option object for that rule.If there is multiple rules (for some reason) it will return option object for the first one, like in the current solution.
Does this PR introduce a breaking change?
No