Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code vision also for local function/let-binding #62

Open
drhumlen opened this issue Sep 22, 2019 · 7 comments
Open

Code vision also for local function/let-binding #62

drhumlen opened this issue Sep 22, 2019 · 7 comments

Comments

@drhumlen
Copy link

Currently we have code vision for top level let-bindings, members and let-binding directly inside a module.

If we could extend the current behaviour to also show type information for local let-bindings that would be amazing imo.

If we just use the same presentation for local let-bindings as top-level ones, this should be a relatively low-hanging fruit now that the ground work is done?

This issue is an extension of the feature from #20 . It's easier to discuss this change in a new non-closed issue.

@drhumlen
Copy link
Author

drhumlen commented Oct 1, 2019

Screenshot 2019-10-01 at 15 54 26

This is one of the reasons I want code vision btw. Often hovering a variable to see its type doesn't work because there's another thing that takes precedence – like this warning.

@vasily-kirichenko
Copy link
Contributor

@drhumlen Ctrl+Q shows a popup window with a symbol type (in C# format).

@drhumlen
Copy link
Author

drhumlen commented Oct 2, 2019

@vasily-kirichenko : I'm on MacOS so the keybinding is different, but it's the action called "Quick documentation" (F1 for me), right? I guess that's better than nothing for an emergency, but really want my type info in F# format, not some C#ified interpretation.

Also moving my cursor from where I'm working, over to the symbol and click it & ctrl+q/f1 throws me out of my coding flow compared to just seeing the inferred type as a Code Vision. So much nicer.

@vasily-kirichenko
Copy link
Contributor

@drhumlen I'd like inferred type to be part of the tooltip, AFAIK it's gonna be possible as soon as Rider moves to standard IDEA tooltips.

@drhumlen
Copy link
Author

drhumlen commented Nov 1, 2019

I’ve noticed that in 2019.3 there’s a type annotation/hint for every var in c#. Would be nice to have the same in F# (rendered inline the same way?)

@endeavour
Copy link

Indeed, this would be very useful!

@drhumlen
Copy link
Author

It can easily become a bit noisy, but if combined with the new "Hold ctrl to view inlay hints" feature, I think this makes more sense now than it did when I opened the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants