Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about @ParametersAreNonnullByDefault? #18

Open
bibarsov opened this issue Nov 6, 2019 · 8 comments
Open

What about @ParametersAreNonnullByDefault? #18

bibarsov opened this issue Nov 6, 2019 · 8 comments
Assignees

Comments

@bibarsov
Copy link

bibarsov commented Nov 6, 2019

I think it's a great replacement for jsr-305's annotations (in the context of IntellijIdea's inspection). Would Jetbrains support that annotation?

@bibarsov
Copy link
Author

bibarsov commented Nov 6, 2019

The same question is for @ParametersAreNullableByDefault

@amaembo
Copy link
Collaborator

amaembo commented Nov 7, 2019

For now, we are not planning to add them.

@matheusstutzel
Copy link

@amaembo any updates on this?

@Sxtanna
Copy link

Sxtanna commented Oct 17, 2021

Sorry but... there are existing semantics for this across several implementations of this annotation within this scope. There is precedent for this, it's really not MUCH more complex, as mentioned in #60 by @amaembo.

Please just make it work how other annotations have worked, for several years.

@overheadhunter
Copy link

For now, we are not planning to add them.

I guess the rationale for this decision was that JSR-305 already provides it and therefore there was no need to add it.

In the meantime the situation has changed, though: org.jetbrains.annotations is a proper java module, so I guess you are well aware of the split package mess that including JSR-305 would cause.

As JetBrains is known to be very supportive of (and many times even leading) new standards, I guess it's time to reconsider.

@CC007
Copy link

CC007 commented Jul 15, 2022

I found this page: https://www.jetbrains.com/help/idea/parametersarenonnullbydefault-annotation.html

Does that mean it is supported now?

@overheadhunter
Copy link

Does that mean it is supported now?

No, not without said dependency which causes split packages:

To use the annotation, add the jsr305 library to module dependencies

@alexei-osipov
Copy link

If there no plans to add equivalent @ParametersAreNonnullByDefault could you please provide a recommendation on what should be used instead. Obviously, JSR 305 can't be used because of deprecation and split package problem since Java 9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants