ChildRules will corrupt the RuleSets of a validator passed to the SetValidator

[sumtec]

FluentValidation version

Any older than 9.4

ASP.NET version

No response

Summary

The ChildRules will use a RuleSetValidatorSelector with a rule set "*". This will overwrite rule sets to be validated specified in the validation context. This will make the child validator malfunctioned.

Steps to Reproduce

		[Fact]
		public void ChildRules_works_with_SetValidator_and_RuleSet() {
			var validator = new RulesetChildValidatorRulesValidator();

			// If the validator inside a child rule specifies a rule set "b",
			// the rules inside the rule set "b" should not be used for the validation
			// if the validation context specified the ruleset "a"
			var result = validator.Validate(new Person {
				Orders = new List<Order> {
					new Order()
				}
			}, options => options.IncludeRuleSets("a"));

			result.Errors.Count.ShouldEqual(1);
			result.Errors[0].PropertyName.ShouldEqual("Surname");			

			// They shouldn't be executed if a different ruleset is chosen.
			result = validator.Validate(new Person {
				Orders = new List<Order> {
					new Order()
				}
			}, options => options.IncludeRuleSets("other"));

			result.Errors.Count.ShouldEqual(0);
		}

		private class RulesetChildValidatorRulesValidator : AbstractValidator<Person> {
			public RulesetChildValidatorRulesValidator() {
				RuleSet("a, b", () => {
					RuleFor(x => x.Surname).NotEmpty();
					RuleFor(x => x).ChildRules(child => {
						child.RuleForEach(o => o.Orders).SetValidator(new RulesetOrderValidator());
					});
				});
			}

			private class RulesetOrderValidator : AbstractValidator<Order> {
				public RulesetOrderValidator() {
					RuleSet("b", () => {
						RuleFor(o => o.ProductName).NotEmpty();
					});
				}
			}
		}

[sumtec]

Please check this one: #1982

[JeremySkinner]

Thanks - good catch. I think your fix in #1982 is correct although I need to test some other scenarios. Once I've done this I'll push out a new release.

[JeremySkinner]

Actually I spoke to soon, it looks like your fix is causing a test failure. Could you take a look at that please?

[JeremySkinner]

Fixed in 11.1.1. Thanks!