Child Validators should receive a reference to the Parent Context #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JeremySkinner
requested changes
May 24, 2022
There was a problem hiding this comment.
Thanks for this, I need to do some testing to make sure there are no unexpected side affects of doing this, but in principle I think this should be fine. A few changes that'll be needed though:
- Changing the method signature of
CloneForChildValidatoris a breaking change, which should be avoided outside of major version releases. This change should be reverted as it's breaking the build. - The calling method (
ChildValidatorAdaptor.CreateNewValidationContextForChildValidator) should be updated to passtrueas the second argument rather than removing the argument entirely. - Please make sure you sign the CLA too or we won't be able to accept the PR
Once you've made these changes I'll be able to get this merged.
Thanks for wanting to be involved!
JeremySkinner
approved these changes
May 24, 2022
|
Merged, thanks. I'll aim to push out a release on Friday. |
JeremySkinner
changed the title
|
Released in 11.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
As I told you in #1942 it would be nice to just restore the link between parent context and children contexts. This will allow to creation of custom root contexts and traverse to root from any child validator. Otherwise, the existence of ParentContext property is just senseless.
As you said it's a volunteer project, so I trying to help you with MR. :)
I removed the obsolete boolean property and change the code to propagate _parent value by default.