Update to support sass-loader 8.x #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the ValidationError when building, caused by sass-loader moving node/dart-sass options to a special `sassOptions` property.
|
@Nothing-Works After checking the recent commits it seems AppVeyor's been failing since eslint was added 3 commits back in 501a6d1. The site isn't loading for me at the moment so I can't check the exact error, but IIRC it was complaining about not being able to find 'node'. Looking at the .eslintrc in the above commit it seems to be referring to line 7 ( tl;dr: AppVeyor isn't even running because eslint config seems broken, but Travis is passing 🎉 |
|
When will a Mix update be pushed that includes this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps the options for Dart/Node-sass in a
sassOptionsobject and updates versions of certain packages according to requirements for sass-loader 8.0.0.Fixes #2206