Update Browsersync snippet regex to use a lookbehind #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I run into the issue because vue.js throws an error when you have a new Vue({
el: '#app'
})<body>
<div id="app">
<pre>
some preformatted code here
</pre>
</div>
</body>This PR will fix it so that the <body>
<div id="app">
<pre>
some preformatted code here
-- <script src="browsersync.js"></script>
</pre>
</div>
++ <script src="browsersync.js"></script>
</body> |
fitztrev
force-pushed
the
browsersync-regex
branch
from
19f26b5
to
9750419
Compare
fitztrev
force-pushed
the
browsersync-regex
branch
from
dc1621e
to
bca23e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current regex is
/(<\/body>|<\/pre>)/iso it will find either the first</body>or</pre>tag, but it should really find the last.This PR adds a lookbehind to the regex to grab the last one instead.
This would be the effect of this change on a page that contains a
</pre>and a</body>:<html> <body> <pre> -- <script src="browsersync.js"></script> </pre> ++ <script src="browsersync.js"></script> </body> </html>Fixes #2239
Fixes laravel/framework#29909
Fixes laravel/framework#30018
Fixes facade/ignition#16
Fixes BrowserSync/browser-sync#1459