Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove notification timeout, fixes #2161 #2179

Merged
merged 1 commit into from Jan 10, 2020
Merged

Remove notification timeout, fixes #2161 #2179

merged 1 commit into from Jan 10, 2020

Conversation

AdrienPoupa
Copy link
Contributor

@AdrienPoupa AdrienPoupa commented Jul 29, 2019 •
edited

Remove timeout notification, this breaks the notifications on KDE

#2161

@AdrienPoupa AdrienPoupa mentioned this pull request Jul 29, 2019
Closed
@AdrienPoupa AdrienPoupa mentioned this pull request Nov 14, 2019
Closed
@vokamut
Copy link

vokamut commented Nov 27, 2019

@JeffreyWay please merge changes

@vokamut
Copy link

vokamut commented Jan 10, 2020

@ecreeth please merge changes

@JeffreyWay
Copy link
Collaborator

Not without a description why we're removing it.

@JeffreyWay JeffreyWay closed this Jan 10, 2020
@AdrienPoupa
Copy link
Contributor Author

AdrienPoupa commented Jan 10, 2020 •
edited

There is ample description here:

#2165
#2161

Please merge @JeffreyWay

@JeffreyWay JeffreyWay reopened this Jan 10, 2020
@JeffreyWay JeffreyWay merged commit b0c2960 into laravel-mix:master Jan 10, 2020
@JeffreyWay
Copy link
Collaborator

Thanks @AdrienPoupa. Sorry for the wait.

@AdrienPoupa
Copy link
Contributor Author

No problem, thank you!

@rodrigopedra
Copy link

Hi @AdrienPoupa great fix, thanks.

Hi @JeffreyWay , can we get a tagged release including this fix? No hurry, right now I am hard coding the commit hash in my package.json but it would be nice to have a release with this fix.

@vokamut
Copy link

vokamut commented Feb 10, 2020

Hi @AdrienPoupa great fix, thanks.

Hi @JeffreyWay , can we get a tagged release including this fix? No hurry, right now I am hard coding the commit hash in my package.json but it would be nice to have a release with this fix.

Issue exists: #2311

@kinglozzer kinglozzer mentioned this pull request Nov 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AdrienPoupa @vokamut @JeffreyWay @rodrigopedra