Update peerDependencies to include React 18
#5133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React 18 was released: https://reactjs.org/blog/2022/03/29/react-v18.html However using react 18 together with `react-select` v5.2.2 (latest version) breaks down with a dependency conflict: ```cmd > npm install npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: app@0.0.0 npm ERR! Found: react@18.0.0 npm ERR! node_modules/react npm ERR! dev react@"^18.0.0" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer react@"^16.8.0 || ^17.0.0" from react-select@5.2.2 npm ERR! node_modules/react-select npm ERR! dev react-select@"5.2.2" from the root project ``` Update `peerDependencies` to allow react 18.
🦋 Changeset detectedLatest commit: 741ea0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 741ea0d:
|
jdufresne
approved these changes
Apr 5, 2022
antosvle
approved these changes
Apr 8, 2022
|
Any chance this could be submitted anytime soon? |
StorytellerCZ
approved these changes
Apr 10, 2022
Rall3n
approved these changes
Apr 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React 18 was released: https://reactjs.org/blog/2022/03/29/react-v18.html
However using react 18 together with
react-selectv5.2.2 (latest version) breaks down with a dependency conflict:This updates
peerDependenciesto allow react 18.Hopefully helps fix #5129