Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent transition props from being forwarded to <input> element in DummyInput component #5057

Merged
merged 7 commits into from Apr 10, 2022

Conversation

Rall3n
Copy link
Collaborator

@Rall3n Rall3n commented Feb 15, 2022

Related to #4922.

When using the animated components with the isSearchable prop set to the value true, React throws warnings regarding unknown event handlers and invalid props.

This is because DummyInput receives these props being a child of the animated ValueContainer component, and tries to apply them to the underlying <input> element.

This PR excludes these props from being spread inside the DummyInput component.

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2022

🦋 Changeset detected

Latest commit: 217f85e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 15, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 217f85e:

Sandbox Source
react-codesandboxer-example Configuration

@Rall3n Rall3n added this to the 5.3 milestone Apr 10, 2022
@Methuselah96 Methuselah96 enabled auto-merge (squash) April 10, 2022 18:09
@Methuselah96 Methuselah96 merged commit bd4ee8a into JedWatson:master Apr 10, 2022
@github-actions github-actions bot mentioned this pull request Apr 10, 2022
@Rall3n Rall3n deleted the animated-DummyInput branch May 1, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants