New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Searchable Act More Like Native HTML Input #948
Comments
I think these were just oversights, @gojohnnygo. The event cancelling thing is clever, while the input value clear seems like a bit of a hack? Either way, I've merged your changes - would be very happy with any other improvements you can make! |
@JedWatson Can you take a look this comparison and give me your thoughts at my first stab? Summary
The whole input value is selected (vs putting the cursor where you clicked) bc I'm not sure if it's worth the trouble. It seems like it can be done but won't elegant. With the changes above, there is one side effect to the options. When you click on the the component, the drop down activates as usual but with only one option: the value the TODO: When component is focused, the cursor should be at the end of the value. |
Just wondering if this is still being actively pursued? I'm oddly enough looking to build something that fits exactly this implementation. |
@gojohnnygo @JedWatson did this ever get implemented? If not, any code you can point me to so I can work on this? |
Oh yeah, I got that hotness...but for an old ver. I'm kind of busy at work atm, but should have time to fix any conflicts and do a PR next week. |
sounds good @gojohnnygo, saw that you had a PR but there was no diff between master. Let me know if you need help. |
TODO: When component is focused, the cursor should be at the end of the value. Was it implemented ? @JedWatson @gojohnnygo |
Sorry I'm tardy to the party! I don't remember what happened to my old branch. I think I was playing too fast and loose with Anywho, pull down this branch to check out the functionality! Here's a recap: For single select...
Functionality works, but there are some things to note...
|
@gojohnnygo -- has there been any update on this? It doesn't look it's been merged into 1.0.0 -- your native functionality is definitely what I'm looking for. |
Hello - In an effort to sustain the We understand this might be inconvenient but in the best interest of supporting the broader community we have to direct our limited efforts to maintain the latest version. If you feel this issue / pull request is still relevant and you'd like us to review it, please leave a comment and we'll do our best to get back to you. |
I was wondering if there were design decisions on why searchable select does not act more like native HTML inputs.
For example:
1.)
ValueComponent
appears to be HTML input value, but it is not.2.) When you click the
ValueComponent
, you expect the cursor to appear where you clicked in the text.I have this PR, which I need to fix (dropped .2 in coverage) and some commits ready, but before I continue:
1.) Is this something worthwhile for the community?
2.) Was this not explored for some reason?
The text was updated successfully, but these errors were encountered: