Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying the "theme" object causes UI disruption #5477

Closed
peeveen opened this issue Nov 11, 2022 · 0 comments · Fixed by #5482
Closed

Modifying the "theme" object causes UI disruption #5477

peeveen opened this issue Nov 11, 2022 · 0 comments · Fixed by #5482
Labels
issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet

Comments

@peeveen
Copy link

peeveen commented Nov 11, 2022

This might just be a documentation issue.

I was experiencing some jittery UI funnies when using react-select controls near the bottom of the screen.
I eventually traced the problem to the theme property modifier function, even though all I was doing was changing one colour.

The problem is demoed here: https://github.com/peeveen/react-select-test

Basically, if I return a new object from the theme modifier function, then weird stuff starts happening.
But if I just alter some properties of the passed-in theme, and return the same object, it's OK.
Even I return a new object that is an exact copy of the theme (i.e. return {...theme}), it still happens.

So perhaps some docs indicating that the theme modifier function should return the same object?
Obviously if you would expect this to work, then I guess it's an actual bug.

@peeveen peeveen added the issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet label Nov 11, 2022
@nderkim nderkim linked a pull request Nov 14, 2022 that will close this issue
@nderkim nderkim closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants