Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid referencing an ID that is not in the DOM #5131

Merged
merged 3 commits into from Apr 10, 2022

Conversation

pcorpet
Copy link
Contributor

@pcorpet pcorpet commented Mar 31, 2022

When the menu is not open, do not set the aria props referencing it.

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2022

🦋 Changeset detected

Latest commit: b5507b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 31, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b5507b7:

Sandbox Source
react-codesandboxer-example Configuration

@pcorpet pcorpet force-pushed the master branch 2 times, most recently from 085202d to c2ad5ba Compare March 31, 2022 13:33
When the menu is not open, do not set the aria props
referencing it.
@Methuselah96 Methuselah96 enabled auto-merge (squash) April 10, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants