Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Invalid ARIA used (aria-control and aria-owns) #5107

Closed
mellis481 opened this issue Mar 15, 2022 · 1 comment
Closed

Accessibility: Invalid ARIA used (aria-control and aria-owns) #5107

mellis481 opened this issue Mar 15, 2022 · 1 comment
Labels
issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet

Comments

@mellis481
Copy link

Violation

Ensure ARIA roles, states, and properties are valid

Issue

There are elements with invalid ARIA attributes and/or values. Examples include:

  • The select component uses aria-control and aria-owns in an invalid manner, which causes the select to not work appropriately. All of the ARIA is on the which is not valid.
  • Additionally, aria-owns and aria-controls are missing corresponding elements (ID references).

User Impact

Assistive technologies may be unable to parse this content.

Code Reference

<input 
    class="select__input"
    autocapitalize="none"
    autocomplete="off"
    autocorrect="off"
    id="react-select-3-input"
    spellcheck="false"
    tabindex="0"
    type="text"
    aria-autocomplete="list"
    aria-expanded="false"
    aria-haspopup="true"
    aria-controls="react-select-3-listbox"
    aria-owns="react-select-3-listbox"
    role="combobox"
    value="" 
    style="color: inherit; background: 0px center; opacity: 1; width: 100%; grid-area: 1 / 2 / auto / auto; font: inherit; min-width: 2px; border: 0px; margin: 0px; outline: 0px; padding: 0px;" 
    aria-describedby="react-select-3-placeholder">

Compliant Code Example

Please see the W3C working compliant example for a select-only combobox:
https://www.w3.org/TR/wai-aria-practices-1.2/examples/combobox/combobox-select-only.html

@mellis481 mellis481 added the issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet label Mar 15, 2022
@Rall3n
Copy link
Collaborator

Rall3n commented Apr 19, 2022

#5131 should have fixed the problem. Therefore I will close this issue.

@Rall3n Rall3n closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet
Projects
None yet
Development

No branches or pull requests

2 participants