Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async select doesn't get repositioned after loading is done #5042

Open
vincaslt opened this issue Feb 4, 2022 · 5 comments
Open

Async select doesn't get repositioned after loading is done #5042

vincaslt opened this issue Feb 4, 2022 · 5 comments
Labels
awaiting-author-response Issues or PRs waiting for more information from the author issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet

Comments

@vincaslt
Copy link

vincaslt commented Feb 4, 2022

This seems like a bug, I saw some discussions about using popper, but seems like custom implementation was chosen. Popper would accept handleResize, which I think fixes this. Does your implementation have a property to observe resize and update position accordingly?

Issue: position is calculated during loading state, after data is loaded, it's not recalculated resulting on off-screen content.
recording: https://www.loom.com/share/ea00e7c4364649e4ace2ec87f6a51a95

@vincaslt vincaslt added the issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet label Feb 4, 2022
@Rall3n
Copy link
Collaborator

Rall3n commented Feb 4, 2022

Hello @vincaslt,

would you please be so kind and include a minimal reproducible example using CodeSandbox as per the issue template?

@Rall3n Rall3n added the awaiting-author-response Issues or PRs waiting for more information from the author label Feb 4, 2022
@vincaslt
Copy link
Author

vincaslt commented Feb 7, 2022

@vincaslt
Copy link
Author

Any news on this?

@labkey-nicka
Copy link

#5256 provided a new implementation for how/when resizing is calculated for the menu. @Methuselah96 do you have any thoughts on how runAutoUpdate() could be invoked again after an async load?

@labkey-nicka
Copy link

A newer issue, specifically #5733, is more the point of what would need to be updated with the current version of react-select (v5.7.4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author-response Issues or PRs waiting for more information from the author issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet
Projects
None yet
Development

No branches or pull requests

3 participants