Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'animatedComponents' is not behave as before in version 5 #4844

Closed
Soberia opened this issue Oct 7, 2021 · 1 comment · Fixed by #4860 or #4892
Closed

'animatedComponents' is not behave as before in version 5 #4844

Soberia opened this issue Oct 7, 2021 · 1 comment · Fixed by #4860 or #4892
Labels
issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer

Comments

@Soberia
Copy link

Soberia commented Oct 7, 2021

Clearing animation in version 5, producing a gap in the Input field.
Same result with disabled custom styles.

React 17.0.2
Microsoft Edge 96.0.1032.0 / Windows 11
Mozila Firefox 93.0 / WSL Ubuntu

Version 4.3.1

4.3.1

Version 5.1.0

5.1.0

@Soberia Soberia added the issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet label Oct 7, 2021
@ebonow ebonow added issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer and removed issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet labels Oct 7, 2021
@ebonow
Copy link
Collaborator

ebonow commented Oct 10, 2021

The recent version update from 4 to 5 included an update to remove the absolute positioning of the SingleValue and Input components, but their container (ValueContainer), needs to be set to grid when:

  1. isMulti = false
  2. isMulti = true and there are no selected values (to allow the placeholder to overlap with the input)

This means however that when the final value is removed, the positioning immediately flips to grid, causing the new value to be sent to a new row until it is removed from the DOM.

Not entirely sure of the best way to address this though I believe the options are to delay the styling of the ValueContainer from flex to grid until after the last item is removed or to perhaps apply styling so that the last MultiValue is given the same grid-cell coordinates as the input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer
Projects
None yet
2 participants