Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing methods to get the actual components #815

Closed
felldo opened this issue Jul 14, 2021 · 0 comments · Fixed by #850
Closed

Missing methods to get the actual components #815

felldo opened this issue Jul 14, 2021 · 0 comments · Fixed by #850
Labels
medium priority An issue or pull request with a medium priority
Milestone

Comments

@felldo
Copy link
Member

felldo commented Jul 14, 2021

The HighLevelComponent and LowLevelComponent interfaces are currently missing methods to get the components like ActionRow or Button.
Possible solutions are to avoid the current methods at all which return i.e. List<HighLevelComponent> and instead offer direct acces to the HighLevelComponents with List<ActionRow> getActionRows() or offer as methods(like we currently also offer for receiving interactions) which are better maintainable as we do not have to add any other methods if there are new component types but on the other side they are not that nice to use as you have to know which classes are possible.

@felldo felldo added the medium priority An issue or pull request with a medium priority label Jul 14, 2021
@felldo felldo added this to the Next Version milestone Jul 14, 2021
@felldo felldo linked a pull request Aug 15, 2021 that will close this issue
@felldo felldo closed this as completed Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority An issue or pull request with a medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant