Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 1: Logging Improvements #1022

Merged
merged 8 commits into from Jan 31, 2022
Merged

Part 1: Logging Improvements #1022

merged 8 commits into from Jan 31, 2022

Conversation

JamesIves
Copy link
Owner

Description

Made improvements to logging by leveraging warning and notice so certain errors are more clear.

Next up: Colors for specific steps so they stand out among the logging.

Testing Instructions

Additional Notes

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022

Codecov Report

Merging #1022 (2ed7bf0) into dev (cdd72ba) will increase coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1022   +/-   ##
=======================================
  Coverage   99.58%   99.59%           
=======================================
  Files           7        7           
  Lines         242      245    +3     
  Branches       66       66           
=======================================
+ Hits          241      244    +3     
  Misses          1        1           
Impacted Files Coverage Δ
src/util.ts 98.18% <50.00%> (ø)
src/lib.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdd72ba...2ed7bf0. Read the comment docs.

@JamesIves JamesIves merged commit 91d4e8f into dev Jan 31, 2022
@JamesIves JamesIves deleted the improve-logging-pt1 branch January 31, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants