Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated spec implementation. "fetch" spec changed in 2017 - Does not lowercase headers #737

Closed
ameliabradley opened this issue Nov 15, 2019 · 5 comments · Fixed by #798
Closed

Comments

@ameliabradley
Copy link

This polyfill is an outdated implementation of the fetch standard.

See this change to the fetch standard in 2017: whatwg/fetch#476

To come back in compliance with the standard, the polyfill needs to stop lowercasing headers, regardless how headers are meant to be interpreted in RFC2616.

Browser implementations such as Chrome are already in compliance and do not lowercase headers for fetch calls.

@naclcaleb
Copy link

@ameliabradley
Copy link
Author

@naclcaleb Sort of? But we can't just remove the lowercasing in normalization. I'm guessing we also need to implement a byte-insensitive match like annevk created in his whatwg PR.

@ameliabradley
Copy link
Author

The reason why this spec update is important is while a server might be expected to handle headers a certain way (as outlined in RFC2616), they do not always comply. I recently came across such an issue.

@JakeChampion
Copy link
Owner

Headers look to not be lowercase when declared via an object but are lowercased when declared via the Header class.

@JakeChampion
Copy link
Owner

PR to resolve this --> #798

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants
@ameliabradley @JakeChampion @naclcaleb and others