-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite code of CitaviImporter to avoid JAXBContext #9539
Comments
We should really work on that to get rid off |
Similar code refactoring: #9880 |
Hello, I'm a new contributor, and I will carefully read the contribution guidelines. Could you please assign this issue to me? @koppor |
@JoleneSun111 If you want, you can also try https://github.com/FasterXML/StaxMate. However, that piece of library is not well documented. I would assume that basic Java Stax transformation is enough to solve the issue. - It is not straight-forward, but IMHO manageable nevertheless. The code is backed by tests, so there should be check if everything goes smoothely. I remember we had the discussions that there have to build local data structures for the lookup of IDs. |
Hi @koppor, I would like to work on this if this issue is still open? |
Since there has not been any activity here since the abandoned pull-request from AvunArasi (#9928), I will assign you @ShailikaS. |
@ShailikaS you have been assigned. Are you still working on this? -- It could be a bit hard to implement... |
The code of
org.jabref.logic.importer.fileformat.CitaviXmlImporter
is written OK, but relies on JAXB. It should be rewritten using StAX-Parser and thus getting rid of a JAXB dependency.The code reads like we do not hit polymorphism in XMLElements (which is not supported by JAXB. See FasterXML/jackson-modules-base#127).
See /src/main/java/org/jabref/logic/importer/fileformat/MedlineImporter.java#L52 for some code hints.
Similar to #9673, the gradle build target
generateEndnoteSource
can be removed and thexsd
file be removed from the source repository.Negleted Implementation Option
Thus, it seems to be "just" to include the dependency to jackson module jakarta-xmlbind and to use Jackson's XMLMapper. Code examples are at https://stackify.com/java-xml-jackson/.
The text was updated successfully, but these errors were encountered: