Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jabref not showing contents of shared database library #8788

Closed
2 tasks done
falschgeldkind opened this issue May 11, 2022 · 10 comments · Fixed by #8793
Closed
2 tasks done

Jabref not showing contents of shared database library #8788

falschgeldkind opened this issue May 11, 2022 · 10 comments · Fixed by #8793
Labels
bug Confirmed bugs or reports that are very likely to be bugs shared-database
Projects
Bugs

Comments

@falschgeldkind
Copy link
Contributor

falschgeldkind commented May 11, 2022 •
edited

JabRef version

Latest development branch build (Build date 2022-05-09)

Operating system

GNU / Linux

Details on version and operating system

Ubuntu 20.04.4 LTS

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Have a shared library with a ton of entries (in my case 39.744)

  2. Try to connect to that library

  3. Watch it saying "Connection [...] established"

  4. Don't see any entries

  5. (Optional) Click on Pull changes from shared database

  6. (Optional) Get the error dialog "The connection to the server has been terminated" and the options to work offline, reconnect and close library

If wanted I can send you a database dump

Appendix

No response
@Siedlerchr
Copy link
Member

Thanks for bringing this to our attention. Can you specify which database you use? MySQL? Postgres? Is there anything in the error log in Jabref. You can send a db dump privately to

web [at] jabref.org

@falschgeldkind
Copy link
Contributor Author

falschgeldkind commented May 13, 2022 •
edited

use a PostgreSQL database

The event log says:
eventlog.LOG

I've sent the database dump to the email address you've given me.

@Siedlerchr
Copy link
Member

Siedlerchr commented May 13, 2022 •
edited

Ah you hit a bug in postgresl: pgjdbc/pgjdbc#1311
The number of parameter in the query is too large...
We need to split the query into multiple smaller ones

Related JabRef code:
at org.jabref@5.7.36/org.jabref.logic.shared.DBMSProcessor.getSharedEntries(Unknown Source)
at org.jabref@5.7.36/org.jabref.logic.shared.DBMSSynchronizer.synchronizeLocalDatabase(Unknown Source)
at org.jabref@5.7.36/org.jabref.logic.shared.DBMSSynchronizer.initializeDatabases(Unknown Source)
at org.jabref@5.7.36/org.jabref.logic.shared.DBMSSynchronizer.openSharedDatabase(Unknown Source)

@falschgeldkind
Copy link
Contributor Author

Oh nice. No bug hunting needed then I guess.
But I thought it might be something on these lines, because when I viewed the data with DataGrip it loaded all of it but did it in multiple 501 elements queries and that worked fine

@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label May 13, 2022
@Siedlerchr Siedlerchr added this to Normal priority in Bugs via automation May 13, 2022
@falschgeldkind
Copy link
Contributor Author

While being here:
how it the column VERSION in "ENTRY" used? I never found a case where that field wasn't 1

@falschgeldkind
Copy link
Contributor Author

falschgeldkind commented May 13, 2022 •
edited

Ok I've got a fix
Never made a push; how do I do a push-request?

@ThiloteE
Copy link
Member

ThiloteE commented May 13, 2022 •
edited

From JabRef GitHub frontpage:

"You are welcome to contribute new features. To get your code included into JabRef, just fork the JabRef repository, make your changes, and create a pull request."

As a general advice: check out https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md for a start. Also, https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace is worth having a look at.

@Siedlerchr
Copy link
Member

@falschgeldkind Thanks for your fix! If I am not mistaken, version is used when multiple people using a shared database work on the same entry

falschgeldkind pushed a commit to falschgeldkind/jabref that referenced this issue May 13, 2022
Fixes Bug JabRef#8788
2a8e555 
added:org.jabref.logic.shared.DBMSProcessor.partitionAndGetSharedEntries(List<Integer> sharedIDs)
Modified:
org.jabref.logic.shared.DBMSSynchronizer.synchronizeLocalDatabase()
falschgeldkind pushed a commit to falschgeldkind/jabref that referenced this issue May 13, 2022
Fixes Bug JabRef#8788
7787acd 
added:org.jabref.logic.shared.DBMSProcessor.partitionAndGetSharedEntries(List<Integer> sharedIDs)
Modified:
org.jabref.logic.shared.DBMSSynchronizer.synchronizeLocalDatabase()

Fixes Bug JabRef#8788

added:org.jabref.logic.shared.DBMSProcessor.partitionAndGetSharedEntries(List<Integer> sharedIDs)
Modified:
org.jabref.logic.shared.DBMSSynchronizer.synchronizeLocalDatabase()
@falschgeldkind falschgeldkind mentioned this issue May 13, 2022
Merged
6 tasks
@falschgeldkind
Copy link
Contributor Author

see #8793

@falschgeldkind
Copy link
Contributor Author

I admit it's not the most performant solution, but it works and fixes the problem

falschgeldkind added a commit to falschgeldkind/jabref that referenced this issue May 13, 2022
@falschgeldkind
Merge pull request #1 from falschgeldkind/patch-1
2b8cbfc 
Changelog entry for JabRef#8788 fix
Bugs automation moved this from Normal priority to Done May 15, 2022
koppor pushed a commit that referenced this issue May 15, 2022
@falschgeldkind @Siedlerchr
Fix for #8788 JabRef not showing contents of shared database library (#…
a90ee23 
…8793)

Co-authored-by: christian.bley <christian.bley@tu-braunschweig.de>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Siedlerchr added a commit to Christina0114/jabref that referenced this issue May 22, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into testMerger
dc70e88 
* upstream/main: (109 commits)
  Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (JabRef#8821)
  Fix single identifier cannot be opened on click (JabRef#8838)
  Add Pubmed/Medline Query Transformer (JabRef#8818)
  adjust and add testcases for FileAnnotationViewModel (JabRef#8830)
  Append config instead of replacing (JabRef#8834)
  Fix eclipse config (JabRef#8835)
  Add Nemo file manager (JabRef#8831)
  Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829)
  Update bouncycalse to new base version (JabRef#8827)
  add: add test cases for FileUtil (JabRef#8810)
  Restrict use of standard streams (JabRef#8816)
  updated 8802 (JabRef#8817)
  Bump pascalgn/automerge-action from 0.15.2 to 0.15.3 (JabRef#8803)
  Bump jackson-dataformat-yaml from 2.13.2 to 2.13.3 (JabRef#8804)
  Bump icu4j-charset from 70.1 to 71.1 (JabRef#8805)
  Fix notifications that overlap task bar (JabRef#8775)
  checkstye
  Default path for ssl key store is nested inside "JabRef" directory (JabRef#8796)
  Add log on disk (JabRef#8791)
  Fix for JabRef#8788 JabRef not showing contents of shared database library (JabRef#8793)
  ...
@falschgeldkind falschgeldkind mentioned this issue Jul 5, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs shared-database
Projects
Bugs
Archived in project
Bugs
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #8788 JabRef not showing contents of shared database library falschgeldkind/jabref
4 participants
@Siedlerchr @koppor @ThiloteE @falschgeldkind