Fix ESLint uppercase #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
requested changes
Nov 20, 2017
README.md
Outdated
|
|
||
| It is a simple wrap for [eslint](https://github.com/eslint/eslint) and works well with eslint from 1.x to the latest version. It runs lint check only in first CI job so that we can speed up build time and reduce unnecessary computation burden for CI service. | ||
| It is a simple wrap for [ESLint](https://github.com/eslint/eslint) and works well with eslint ESLint 1.x to the latest version. It runs lint check only in first CI job so that we can speed up build time and reduce unnecessary computation burden for CI service. |
|
@ai Good catch for capitalization consistency! we should do |
JLHwung
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According ESLint website, the team prefer to capitalize ES and L.
@JLHwung should we update the docs too?
Also thanks for the project. I am planning to use it in Autoprefixer and PostCSS.