Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menus: rounded selection #536

Merged
merged 2 commits into from Oct 30, 2022
Merged

Menus: rounded selection #536

merged 2 commits into from Oct 30, 2022

Conversation

DevCharly
Copy link
Collaborator

This PR enables using "rounded" selection for menu items.
It also enables using different selection colors for top-level JMenus.

This is not yet used in any theme, but intended to be used
for macOS themes (see PR #533) and future Windows 11 style themes.

Perhaps this should also be used for existing themes to make menus look more beautiful.
Any opinions?

Example

(left image shows rounded selection; right image shows default look)

image image

UI properties for above screenshot (see Application properties files):

# make menu item margins larger (default is 3,6,3,6)
@menuItemMargin = 3,9,3,9

MenuBar.selectionBackground = darken(@menuBackground,15%,derived)
MenuBar.selectionForeground = @foreground

MenuBar.selectionInsets = 1,0,1,0
MenuBar.selectionEmbeddedInsets = 3,0,3,0

MenuItem.selectionInsets = 0,3,0,3
MenuItem.selectionArc = 8

- support different selection colors for top-level JMenus
- fixed styling of underline selection properties for top-level JMenus
@DevCharly DevCharly added this to the 3.0 milestone May 15, 2022
@j-dimension
Copy link

Perhaps this should also be used for existing themes to make menus look more beautiful.
Any opinions?

Awesome work, looks great to my eyes, even with non-macOS / non-Win11 UIs. But I am not a UI / UX expert :-)

DevCharly added a commit that referenced this pull request Oct 30, 2022
…and `selectionInsets` or `selectionArc` are set (PR #536)
@DevCharly DevCharly merged commit 0c5016f into main Oct 30, 2022
@DevCharly DevCharly deleted the menus-rounded-selection branch October 30, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants