Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reveal icon is clickable even if JPasswordField is disabled #501

Closed
medmedin2014 opened this issue Mar 15, 2022 · 6 comments
Closed

Reveal icon is clickable even if JPasswordField is disabled #501

medmedin2014 opened this issue Mar 15, 2022 · 6 comments
Milestone

Comments

@medmedin2014
Copy link

Even if JPasswordField is disabled, it's possible to click on reveal icon and show/hide typed password.

FlatLaF v2.0.2

Peek 2022-03-15 13-12

@DevCharly
Copy link
Collaborator

And why is this a problem?
You still cannot modify the password.

@medmedin2014
Copy link
Author

Even if the content cannot be modified but if a component is disabled then all what is inside it should be disabled. If I show both clear and reveal icons on a password field then disable it, the clear icon disappears while reveal icon remains working. I don't know if my point is valid ;)

@sysoutch
Copy link

sysoutch commented Aug 25, 2022

yeah seems kinda weird being able to click it when disabled, since the reveal button is inside the disabled component it should be disabled too imho. maybe u could start a poll on this :)

@Plyha
Copy link
Contributor

Plyha commented Aug 26, 2022

Hello, I also faced the same problem. For example, an application that can store multiple accounts, it would be nice if the user could not see the password if field is disabled.

DevCharly added a commit that referenced this issue Sep 11, 2022
@DevCharly
Copy link
Collaborator

Thanks for all your feedback.

I've changed it in latest 2.5-SNAPSHOT: https://github.com/JFormDesigner/FlatLaf#snapshots

Now the reveal button is hidden if the password field is disabled.

@DevCharly DevCharly added this to the 2.5 milestone Sep 11, 2022
@Plyha
Copy link
Contributor

Plyha commented Sep 11, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants